On Mon, Apr 02, 2007 at 04:31:22PM -0700, Badari Pulavarty wrote: > On Mon, 2007-04-02 at 14:09 +0200, Nick Piggin wrote: > > Updated aops patchset against 2.6.21-rc5. > > > > http://www.kernel.org/pub/linux/kernel/people/npiggin/patches/new-aops/ > > > > Sorry to send you so many silly fixes, but I though it would > be easy to review individual ones. On the contrary, thanks for sending them all :) In regards to this hunk, my aim is simply to mirror generic_perform_write test which gives us a free oops if write_end is NULL. I'll add a comment there (eventually this will all go away anyway). The rest of your patches look good I think, so consider them applied unless I reply individually. Thanks, Nick > > Thanks, > Badari > > --- > mm/filemap.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > Index: linux-2.6.21-rc5/mm/filemap.c > =================================================================== > --- linux-2.6.21-rc5.orig/mm/filemap.c 2007-04-02 13:45:56.000000000 -0700 > +++ linux-2.6.21-rc5/mm/filemap.c 2007-04-02 16:23:48.000000000 -0700 > @@ -2107,7 +2107,7 @@ int pagecache_write_end(struct file *fil > const struct address_space_operations *aops = mapping->a_ops; > int ret; > > - if (aops->write_begin) { > + if (aops->write_end) { > ret = aops->write_end(file, mapping, pos, len, copied, > page, fsdata); > } else { > > > - To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
