On Mon, 2007-04-02 at 14:09 +0200, Nick Piggin wrote: > Updated aops patchset against 2.6.21-rc5. > > http://www.kernel.org/pub/linux/kernel/people/npiggin/patches/new-aops/ > > Files/dirs are 2.6.21-rc5-new-aops* > > Contains numerous fixes from Mark and myself -- I'd say the core code is > getting reasonably stable at this point. ext3_write_failure() conversion is NOT quite correct. Old code was returing failure of do_journal_get_write_access(), where as your changes will return journal_stop(). Thanks, Badari --- fs/ext3/inode.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) Index: linux-2.6.21-rc5.aop/fs/ext3/inode.c =================================================================== --- linux-2.6.21-rc5.aop.orig/fs/ext3/inode.c 2007-04-02 13:37:16.000000000 -0700 +++ linux-2.6.21-rc5.aop/fs/ext3/inode.c 2007-04-02 13:37:35.000000000 -0700 @@ -1196,8 +1196,11 @@ skip: break; if (ext3_should_journal_data(mapping->host)) { ret = do_journal_get_write_access(handle, bh); - if (ret) - goto skip; + if (ret) { + unlock_page(page); + page_cache_release(page); + return ret; + } } /* * block_start here becomes the first block where the current iteration - To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
