On Wed, Mar 14, 2007 at 11:23:05PM -0700, Joel Becker wrote: > On Thu, Mar 15, 2007 at 05:36:42AM +0100, Nick Piggin wrote: > > On Wed, Mar 14, 2007 at 09:13:29PM -0700, Mark Fasheh wrote: > > > Are we going to get rid of the file and intr arguments btw? I'm not sure > > > intr is useful, and mapping is probably enough to get whatever we inside > > > ->write_begin / ->write_end. > > > > Yeah, I was going to, but I had this version ready to go so decided > > to leave them in at the last minute. We can definitely take them out > > if people agree. > > You're really going to need the file argument around. Some > folks care about file->private_data, etc. A good example is > nfs_updatepage() from nfs_commit_write(). There's a context on the > filp. Mapping can get back to the inode via ->host, but not to the > struct file. OK, I'll keep the file around unless we see a better alternative. Thanks for pointing that out. - To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
