On Wed, 2007-02-21 at 19:28 +0100, Miklos Szeredi wrote: > > > This flag is checked in msync() and __fput(), and if set, the file > > > times are updated and the flag is cleared > > > > Why not also check inside vfs_getattr? > > This is the minimum, that the standard asks for. > > Note, your porposal would touch the times in vfs_getattr(), which > means, that the modification times would depend on the time of the > last stat() call, which is not really right, though it would still be > conforming. > > It is much saner, if the modification time is always the time of the > last write() or msync(). I disagree. The above doesn't allow a program like 'make' to discover whether or not the file has changed by simply calling stat(). Instead, you're forcing a call to msync()+stat(). Cheers Trond - To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
