Re: libfs.c:simple_lookup

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 2007-02-19 at 21:09 +0100, Jan Engelhardt wrote:
> Hello,
> 
> 
> simple_lookup() in fs/libfs.c does some extra steps, namely
> 
> 	dentry->d_op = &simple_dentry_operations;
> 	d_add(dentry, NULL);
> 
> as far as I understand, this creates a negative dentry which will be 
> deleted sometime later again. Is not it easier to not create it at all 
> (since it is not going to be existent anyway)?

I'm not sure I understand the question, so allow me to restate a similar
question, and you can tell me if we're asking the same thing.

In general, the negative dentry avoids the overhead of looking up a
non-existent entry more than once by "remembering" that the entry does
not exist.  Since there is almost no overhead to calling
simple_lookup(), would be be better off simply returning without
creating the negative dentry (and letting simple_lookup be called more
often)?

Shaggy
-- 
David Kleikamp
IBM Linux Technology Center

-
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [Samba]     [Device Mapper]     [CEPH Development]
  Powered by Linux