Hi, On Tue, 2006-12-12 at 02:52 +1100, Nick Piggin wrote: > Nick Piggin wrote: > > Mark Fasheh wrote: > > >> ->commit_write() would probably do fine. Currently, block_prepare_write() > >> uses it to know which buffers were newly allocated (the file system > >> specific > >> get_block_t sets the bit after allocation). I think we could safely move > >> the clearing of that bit to block_commit_write(), thus still allowing > >> us to > >> detect and zero those blocks in generic_file_buffered_write() > > > > > > OK, great, I'll make a few patches and see how they look. What did you > > think of those other uninitialised buffer problems in my first email? > > Hmm, doesn't look like we can do this either because at least GFS2 > uses BH_New for its own special things. > What makes you say that? As far as I know we are not doing anything we shouldn't with this flag, and if we are, then I'm quite happy to consider fixing it up so that we don't, Steve. - To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
