On Fri, Dec 01, 2006 at 10:11:14AM +0900, OGAWA Hirofumi wrote: > Nick Piggin <npiggin@xxxxxxx> writes: > > > I would be happy if you come up with a quick fix, I'm just trying to > > stamp out a few big bugs in mm. However I did prefer my way of moving > > all the exapand code into generic_cont_expand, out of prepare_write, and > > avoiding holding the target page locked while we're doing all the expand > > work (strictly, you might be able to get away with this, but it is > > fragile and ugly). > > > > AFAIKS, the only reason to use prepare_write is to avoid passing the > > get_block into generic_cont_expand? > > IIRC, because generic_cont_expand is designed as really generic. It > can also use for non moronic filesystem. > > In the case of reiserfs, it ->prepare_write might be necessary. Yes I see :( Well, maybe we should use your alternate patch, then. I have a few questions on it. - To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
