Re: [PATCH] GFS2: don't panic needlessly

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

Thanks for the patch. Now applied to the GFS2 git tree,

Steve.

On Sat, 2006-10-28 at 03:03 +0400, Alexey Dobriyan wrote:
> First, SLAB_PANIC is unjustified. Second, all error propagating and backing out
> is in place.
> 
> Signed-off-by: Alexey Dobriyan <adobriyan@xxxxxxxxx>
> ---
> 
>  fs/gfs2/main.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> --- a/fs/gfs2/main.c
> +++ b/fs/gfs2/main.c
> @@ -84,8 +84,8 @@ static int __init init_gfs2_fs(void)
>  
>  	gfs2_inode_cachep = kmem_cache_create("gfs2_inode",
>  					      sizeof(struct gfs2_inode),
> -					      0, (SLAB_RECLAIM_ACCOUNT|
> -					      SLAB_PANIC|SLAB_MEM_SPREAD),
> +					      0,  SLAB_RECLAIM_ACCOUNT|
> +					          SLAB_MEM_SPREAD,
>  					      gfs2_init_inode_once, NULL);
>  	if (!gfs2_inode_cachep)
>  		goto fail;
> 

-
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [Samba]     [Device Mapper]     [CEPH Development]
  Powered by Linux