On Wed, Oct 18, 2006 at 01:35:51AM -0700, Andrew Morton wrote: > On Wed, 18 Oct 2006 01:31:03 -0700 > Andrew Morton <akpm@xxxxxxxx> wrote: > > > > One, rather unfortunate, fact is that struct path is also defined in > > > include/linux/reiserfs_fs.h as something completely different - reiserfs > > > specific. > > > > > > Any thoughts? > > > > > > > reiserfs is being bad. s/path/reiserfs_path/g > > There's also drivers/md/dm-mpath.h's struct path. Renaming fs/namei.c's > `struct path' to `struct namei_path' would be prudent. Yuck... If we really want to switch to it (and I can give you a dozen examples of possible users right now - starting with struct file), putting namei_ into it is both uninformative and ugly. I'm not sure what would be the good name here; "pathname" comes to mind, but it suggests that we are dealing with a string. And "location" is too vague (and probably would cause fsckloads of conflicts itself). Suggestions? "pathname" would almost work; the difference is that this is not a string but a node in tree that string resolves to. - To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
