On Mon, Oct 09, 2006 at 01:33:32PM -0700, Andrew Morton wrote: > On Mon, 9 Oct 2006 16:10:48 -0400 > Josef Sipek <jsipek@xxxxxxxxxxxxxxxxx> wrote: > > > This patch moves code out of fs/xattr.c:listxattr into a new function - > > vfs_listxattr. The code for vfs_listxattr was originally submitted by Bill > > Nottingham <notting@xxxxxxxxxx> to Unionfs. > > That tells us what the patch does. In general, please be sure to also tell > us *why* you prepared a patch. > > Does this patch allow unionfs to be loaded into an otherwise unpatched > kernel.org kernel? If so, that seems to be a good reason for including > this patch into the mainline kernel. Sorry about that. The reason for this submission is to make the listxattr code in fs/xattr.c a little cleaner (as well as to clean up some code in Unionfs.) Currently, Unionfs has vfs_listxattr defined in its code. I think that's very ugly, and I'd like to see it (re)moved. The logical place to put it, is along side of all the other vfs_*xattr functions. Overall, I think this patch is benefitial for both kernel.org kernel and Unionfs. Josef "Jeff" Sipek. -- Humans were created by water to transport it upward. - To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html