==> Regarding [PATCH take2 0/5] dio: clean up completion phase of direct_io_worker(); Zach Brown <zach.brown@xxxxxxxxxx> adds: zach.brown> Andrew, testing has now uncovered 2 bugs in this patch set that zach.brown> have been fixed. XFS and the generic file path were using zach.brown> blkdev_direct_IO()'s return code to test if ops were in flight zach.brown> and were missing EIOCBQUEUD. They've been fixed. I think this zach.brown> can bake in -mm now. zach.brown> Here's the initial introduction to the series with an update on zach.brown> what's been tested: zach.brown> There have been a lot of bugs recently due to the way zach.brown> direct_io_worker() tries to decide how to finish direct IO zach.brown> operations. In the worst examples it has failed to call zach.brown> aio_complete() at all (hang) or called it too many times zach.brown> (oops). zach.brown> This set of patches cleans up the completion phase with the zach.brown> goal of removing the complexity that lead to these bugs. We zach.brown> end up with one path that calculates the result of the zach.brown> operation after all off the bios have completed. We decide zach.brown> when to generate a result of the operation using that path zach.brown> based on the final release of a refcount on the dio structure. zach.brown> I tried to progress towards the final state in steps that were zach.brown> relatively easy to understand. Each step should compile but I zach.brown> only tested the final result of having all the patches applied. zach.brown> I've tested these on low end PC drives with aio-stress, the zach.brown> direct IO tests I could manage to get running in LTP, orasim, zach.brown> and some home-brew functional tests. zach.brown> In http://lkml.org/lkml/2006/9/21/103 IBM reports success with zach.brown> ext2 and ext3 running DIO LTP tests. They found that XFS bug zach.brown> which has since been addressed in the patch series. We tested this on one of our smaller systems using ext3, and it holds up. There was no performance degradation observed. I would like to see some raw testing; I'll see if I can't get that done. As with the last posting, I reviewed the direct I/O path with the patches applied, and it's much nicer than before. Acked-by: Jeff Moyer <jmoyer@xxxxxxxxxx> - To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
