On Wed, 2006-09-06 at 17:34 +0200, Jan Kara wrote: > > On Wed, 2006-09-06 at 14:47 +0200, Jan Kara wrote: > > > > > > Andrew, what should we do ? Do you suggest handling this in jbd > > > > itself (like this patch) ? > > > Actually that part of commit code needs rewrite anyway (and after that > > > rewrite you get rid of ll_rw_block()) because of other problems - the > > > code assumes that whenever buffer is locked, it is being written to disk > > > which is not true... I have some preliminary patches for that but they > > > are not very nice and so far I didn't have enough time to find a nice > > > solution. > > > > Are you okay with current not-so-elegant fix ? > Actually I don't quite understand how it can happen what you describe > (so probably I missed something). How it can happen that some buffers > are unmapped while we are committing them? journal_unmap_buffers() > checks whether we are not committing truncated buffers and if so, it > does not do anything to such buffers... > Bye > Honza Yep. I spent lot of time trying to understand - why they are not getting skipped :( But my debug clearly shows that we are clearing the buffer, while we haven't actually submitted to ll_rw_block() code. (I added "track" flag to bh and set it in journal_commit_transaction() when we add them to wbuf[] and clear it in ll_rw_block() after submit. I checked for this flag in journal_unmap_buffer() while clearing the buffer). Here is what my debug shows: buffer is tracked bh ffff8101686ea850 size 1024 Call Trace: [<ffffffff8020b395>] show_trace+0xb5/0x370 [<ffffffff8020b665>] dump_stack+0x15/0x20 [<ffffffff8030d474>] journal_invalidatepage+0x314/0x3b0 [<ffffffff802fe948>] ext3_invalidatepage+0x38/0x40 [<ffffffff80282750>] do_invalidatepage+0x20/0x30 [<ffffffff80260613>] truncate_complete_page+0x23/0x50 [<ffffffff8026070d>] truncate_inode_pages_range+0xcd/0x300 [<ffffffff80260950>] truncate_inode_pages+0x10/0x20 [<ffffffff802686ff>] vmtruncate+0x5f/0x100 [<ffffffff8029d880>] inode_setattr+0x30/0x140 [<ffffffff802ff8cb>] ext3_setattr+0x1bb/0x230 [<ffffffff8029daee>] notify_change+0x15e/0x320 [<ffffffff8027f973>] do_truncate+0x53/0x80 [<ffffffff802800f8>] sys_ftruncate+0xf8/0x130 [<ffffffff80209d5a>] system_call+0x7e/0x83 Thanks, Badari - To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
