On Aug 26, 2006 01:20 +0400, Alexey Dobriyan wrote: > * Rougly half of callers already do it by not checking return value > * Those who check it printk something, however, slab_error already printed > the name of failed cache. > * XFS BUGs on failed kmem_cache_destroy which is not the decision > low-level filesystem driver should make. Converted to ignore. If you are changing this, then it is better to add the BUG() at destroy time right now. This makes it MUCH easier to track down the cause (i.e. when there are slab items that failed to be released, instead of getting a BUG() the next time someone tries to load that module and the slab already exists). Just because a lot of code doesn't check the return value, doesn't mean it shouldn't be possible to do so. Consider if there is lots of code that doesn't check the kmalloc() return value - just because it works most of the time doesn't mean we should start removing the checks for a failed kmalloc(). Cheers, Andreas -- Andreas Dilger Principal Software Engineer Cluster File Systems, Inc. - To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
