On Sat, Aug 26, 2006 at 01:21:10AM +0400, Alexey Dobriyan wrote: > un-, de-, -free, -destroy, -exit, etc functions should in general > return void. Also, > @@ -2411,7 +2410,6 @@ int kmem_cache_destroy(struct kmem_cache > list_add(&cachep->next, &cache_chain); > mutex_unlock(&cache_chain_mutex); > unlock_cpu_hotplug(); > - return 1; > } > > if (unlikely(cachep->flags & SLAB_DESTROY_BY_RCU)) Shouldn't this return, as otherwise there is a significant change in the code path followed. -ben -- "Time is of no importance, Mr. President, only life is important." Don't Email: <dont@xxxxxxxxx>. - To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
