On Thu, Aug 24, 2006 at 10:33:11PM +0100, David Howells wrote: > From: David Howells <dhowells@xxxxxxxxxx> > > Dissociate the generic_writepages() function from the mpage stuff, moving its > declaration to linux/mm.h and actually emitting a full implementation into > mm/page-writeback.c. > > The implementation is a partial duplicate of mpage_writepages() with all BIO > references removed. > > It is used by NFS to do writeback. This duplication is rather unfortunate, but I don't see a way to distangle this any better, so ok. > @@ -693,6 +693,8 @@ out: > * the call was made get new I/O started against them. If wbc->sync_mode is > * WB_SYNC_ALL then we were called for data integrity and we must wait for > * existing IO to complete. > + * > + * !!!! If you fix this you should check generic_writepages() also!!!! This isn't very elegant comment style :) What about a little less shouting.. > int pdflush_operation(void (*fn)(unsigned long), unsigned long arg0); > +extern int generic_writepages(struct address_space *mapping, > + struct writeback_control *wbc); > int do_writepages(struct address_space *mapping, struct writeback_control *wbc); please try to fit the style of the surrounding prototypes, that is no 'extern' - To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
