On Tue, 2006-08-22 at 14:49 -0500, Steve French (smfltc) wrote: > Now that generic_file_llseek locks the inode, do we need to have anyone > use remote_llseek? > > Although remote_llseek is newer, it does a lock_kernel which seems > excessive, unless it has to do with > some isize_write race issue it is trying to avoid. > > The cifs code would probably be fine with the change to the (presumably > faster) generic_file_llseek, > and perhas the nfs code as weel.. NFS has issues with isize_write(). We can't use it 'cos it presupposes that all size changes will occur under the inode->i_mutex. Unfortunately, remote servers don't take our local inode->i_mutex. Cheers, Trond - To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html