On Mon, Jul 31, 2006 at 11:02:51PM -0700, Andrew Morton wrote: > On Mon, 31 Jul 2006 16:57:02 +0400 > Evgeniy Dushistov <dushistov@xxxxxxx> wrote: > > Looks good to me. > > Is there any need to be checking ->index? Normally we simply use the > sequence: > > lock_page(page); > if (page->mapping == NULL) > /* truncate got there first */ > > to handle this case. Yes, I made it in analogy with `find_lock_page' and missed fact that if we increment usage counter of page, we have no need to check page->index. Need another patch? -- /Evgeniy - To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html