Ar Iau, 2006-07-27 am 19:01 +0300, ysgrifennodd Pekka J Enberg: > > Yes revoke calls it too, but is that sufficient, or do we need ->revoke? > > Ouch. You are right. I need to stick that invalidate_inode_pages2 > > back in there. The do_fsync call takes care of writes only, obviously. On Thu, 27 Jul 2006, Alan Cox wrote: > Actually that isn't true either - it takes care of *regular file* > writes. Devices will need a revoke hook and thats really probably only > right. If they don't have one just -EOPNOTSUPP, you can check it before > you begin any other processing so its easy to check. Ah, you're right. So I'll make a generic_file_revoke and f_ops->revoke that can be used by filesystems to do sync and inode page invalidation. That hook should be sufficient for device drivers too? Pekka - To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html