On Sat, Jul 08, 2006 at 10:12:52PM +0400, Alexey Dobriyan wrote: > * Don't do inode => vnode => inode conversion, use passed inode directly > * Don't allocate and free memory on each call > * As a consequence, don't have a chance to return ENOMEM, which would be > truly bizarre error code for this ioctl. Yoohoo, I'm over here... send XFS patches to me please. Thats the second time I've asked you that... is there a problem there? > + return put_user(inode->i_generation, (int __user *)arg); > + Looks fine, I'll merge it when I'm in the office tomorrow. You've tested this change, right? cheers. -- Nathan - To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html