<snip> > @@ -1018,10 +1018,14 @@ struct ecryptfs_cipher_code_str_map_elem > /* List in order of probability. */ > static struct ecryptfs_cipher_code_str_map_elem > ecryptfs_cipher_code_str_map[] = { > - {"aes", 0x07}, > + {"aes", 0x07}, /* AES-128 */ > {"blowfish", 0x04}, > {"des3_ede", 0x02}, > - {"cast5", 0x03} > + {"cast5", 0x03}, > + {"twofish", 0x0a}, > + {"cast6", 0x0b}, > + {"aes", 0x08}, /* AES-192 */ > + {"aes", 0x09} /* AES-256 */ > }; A ridiculously trivial suggestion here, but maybe just add the last element of this table as such: {"aes", 0x09},... Not that it's overly important, but it'll kill a couple unnecessary lines in the next patch to this table. Also, why not simply include the key-size in the name (e.g. {"aes192", 0x08},}? Granted, I haven't looked around at how this string is being used in your code... -tim - To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html