On Mon, Jun 19, 2006 at 10:02:16AM -0700, Dave Hansen wrote:
> Very true. How about this to fix it?
>
> --- lxc/fs//open.c~C8.1-fix-faccesat 2006-06-19 09:59:41.000000000 -0700
> +++ lxc-dave/fs//open.c 2006-06-19 10:01:25.000000000 -0700
> @@ -546,8 +546,12 @@ asmlinkage long sys_faccessat(int dfd, c
> special_file(nd.dentry->d_inode->i_mode))
> goto out_path_release;
>
> - if(__mnt_is_readonly(nd.mnt) || IS_RDONLY(nd.dentry->d_inode))
> - res = -EROFS;
> + res = mnt_want_write(nd.mnt);
> + if (!res) {
> + mnt_drop_write(nd.mnt);
> + if(IS_RDONLY(nd.dentry->d_inode))
> + res = -EROFS;
> + }
So access() can make remount r/o fail? Uh-oh...
-
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
