David Howells <dhowells@xxxxxxxxxx> wrote:
> Peter Zijlstra <a.p.zijlstra@xxxxxxxxx> wrote:
>
> > - if (unlikely(vma->vm_flags & VM_SHARED)) {
> > + if (unlikely(vma->vm_flags & (VM_SHARED|VM_WRITE) ==
> > + VM_SHARED|VM_WRITE) {
>
> NAK!
>
> "==" is higher priority than "|". What you meant was:
>
> - if (unlikely(vma->vm_flags & VM_SHARED)) {
> + if (unlikely(vma->vm_flags & (VM_SHARED|VM_WRITE) ==
> + (VM_SHARED|VM_WRITE)) {
Or, rather:
- if (unlikely(vma->vm_flags & VM_SHARED)) {
+ if (unlikely(vma->vm_flags & (VM_SHARED|VM_WRITE) ==
+ (VM_SHARED|VM_WRITE))) {
It has insufficient closing brackets otherwise.
David
-
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
