On Mon, Jun 12, 2006 at 11:29:24AM -0700, Dave Hansen wrote: > On Mon, 2006-06-12 at 19:18 +0100, Al Viro wrote: > > On Wed, Jun 07, 2006 at 05:10:36PM -0700, Dave Hansen wrote: > > > + error = mnt_want_write(oldnd.mnt); > > > if (error) > > > goto exit1; > > > > > > + error = do_path_lookup(newdfd, newname, LOOKUP_PARENT, &newnd); > > > + if (error) > > > + goto exit2; > > > + > > > + error = mnt_want_write(oldnd.mnt); > > > > WTF? Why raise it twice? > > That's a bug. The second raise should be for newnd.mnt. No, it should not. These two should be collapsed into one and done after we'd checked that vfsmounts are equal - To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
