IMHO, 3 (three) if's for a whole fs don't look that bad. on the other side, you'd need to audit much more of almost the same lines ... thanks, Alex >>>>> Jeff Garzik (JG) writes: JG> With extents and 48bit, you have multiple code paths to audit, regardless. JG> If applied to ext3, you have to audit JG> fs/ext3/*.c: JG> if (extents) JG> ... JG> else JG> ... JG> as opposed to JG> fs/ext3/*.c: JG> ... non-extent code JG> fs/ext4/*.c: JG> ... extent code - To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html