On Thu, 2006-06-08 at 13:23 +0200, Herbert Poetzl wrote: > On Wed, Jun 07, 2006 at 05:10:36PM -0700, Dave Hansen wrote: > > diff -puN fs/namei.c~elevate-writers-vfs_rename-part1 fs/namei.c > > --- lxc/fs/namei.c~elevate-writers-vfs_rename-part1 2006-06-07 16:53:26.000000000 -0700 > > +++ lxc-dave/fs/namei.c 2006-06-07 16:53:26.000000000 -0700 > > @@ -2507,29 +2507,37 @@ static int do_rename(int olddfd, const c > > if (error) > > goto exit; > > > > - error = do_path_lookup(newdfd, newname, LOOKUP_PARENT, &newnd); > > + error = mnt_want_write(oldnd.mnt); > > if (error) > > goto exit1; > > same here, I'd suspect it changes the return code > for the case where the 'files' reside on different > mount points from -EXDEV and for the busy case > from -EBUSY to -EROFS .... > > don't get me wrong, I'm probably fine with those > changes if they are consistant and do not depend > on whether the inode is RO or the entire mnt point I think I might be able to fix this one up a bit by changing the order around. I'll have a good look at it. -- Dave - To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
