Christoph Hellwig <hch@xxxxxx> wrote: > > Same as with already do with the file operations: > keep them in .rodata and prevents people from doing runtime patching. It would occasionally be nice to be the second person to compile something. fs/cifs/inode.c: In function `cifs_get_inode_info_unix': fs/cifs/inode.c:187: warning: assignment of read-only member `readpages' fs/cifs/inode.c: In function `cifs_get_inode_info': fs/cifs/inode.c:525: warning: assignment of read-only member `readpages' Steve, you should have separate sets of a_ops and select the appropriate one for inode->i_data.a_ops, rather than scribbling on cifs_addr_ops. - To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html