On Mon, 2006-04-24 at 11:26 -0700, Ravikiran G Thirumalai wrote: > On Mon, Apr 24, 2006 at 10:48:32AM -0700, Mingming Cao wrote: > > On Fri, 2006-04-21 at 15:09 -0700, Andrew Morton wrote: > > > > > > > I think it would be saner to explicitly specify the size of the field. > > > That means using s32 and s64 throughout this code. > > > > > > > Agree. Will use s64 in this code. As s32 has the same issue with what we > > have(unsigned long) on 32 bit machine today: it is not enough for ext3 > > to support more than 2**31 free blocks, and also obviously not enough > > for 64 bit ext3 that Laurent is working on. > > I think Andrew's suggestion was to change global counter to s64 and local > counter to s32. That way we avoid allocating a 64 bit local counter on 64 > bit systems when we could do with a 32 bit counter. (although there is no > real space savings with current alloc_percpu ;), but hopefully that will > change in the future) > Oh, I see. :-) I shall have the updated patch soon. Mingming - To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
