David Howells <dhowells@xxxxxxxxxx> wrote:
>
> > > +struct file *get_empty_filp(int kernel)
> >
> > I'd suggest a new get_empty_kernel_filp(void) rather than providing a magic
> > argument. (we can still have the magic argument in the new
> > __get_empty_filp(int), but it shouldn't be part of the caller-visible API).
> > ...
> > It would be more flexible to make the caller pass in the flags directly.
>
> So:
>
> struct file *get_empty_kernel_filp(unsigned short flags);
>
> which devolves to get_empty_filp() if flags == 0?
>
argh, I forgot about the flag. Oh well. I'd suggest:
static inline struct file *get_empty_filp(void)
{
return __get_empty_filp(0);
}
static inline struct file *get_empty_kernel_filp(void)
{
return __get_empty_filp(0);
}
-
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
