Re: [PATCH 01/12] common/encrypt: separate data and inode nonces

Anand Jain <anand.jain@xxxxxxxxxx> · Tue, 31 Oct 2023 22:13:39 +0800

On 11/10/2023 04:25, Josef Bacik wrote:

From: Sweet Tea Dorminy <sweettea-kernel@xxxxxxxxxx>

btrfs will have different inode and data nonces, so we need to be
specific about which nonce each use needs. For now, there is no
difference in the two functions.

Signed-off-by: Sweet Tea Dorminy <sweettea-kernel@xxxxxxxxxx>
---

Looks good.

Reviewed-by: Anand Jain <anand.jain@xxxxxxxxxx>

And, as Eric pointed out, the naming can be more intuitive. Keywords 

such as 'inode' and 'extent' will make them more intuitive, rather than 

'file' and 'data,' IMO.

Thanks, Anand