Re: [PATCH 6/12] wifi: mac80211: Do not include crypto/algapi.h
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- To: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>, Linux Crypto Mailing List <linux-crypto@xxxxxxxxxxxxxxx>, Eric Biggers <ebiggers@xxxxxxxxxx>, "Theodore Y.Ts'o" <tytso@xxxxxxx>, Jaegeuk Kim <jaegeuk@xxxxxxxxxx>, linux-fscrypt@xxxxxxxxxxxxxxx, Richard Weinberger <richard@xxxxxx>, linux-mtd@xxxxxxxxxxxxxxxxxxx, Marcel Holtmann <marcel@xxxxxxxxxxxx>, Johan Hedberg <johan.hedberg@xxxxxxxxx>, Luiz Augusto von Dentz <luiz.dentz@xxxxxxxxx>, linux-bluetooth@xxxxxxxxxxxxxxx, Ilya Dryomov <idryomov@xxxxxxxxx>, Xiubo Li <xiubli@xxxxxxxxxx>, Jeff Layton <jlayton@xxxxxxxxxx>, ceph-devel@xxxxxxxxxxxxxxx, Steffen Klassert <steffen.klassert@xxxxxxxxxxx>, "David S. Miller" <davem@xxxxxxxxxxxxx>, netdev@xxxxxxxxxxxxxxx, linux-wireless@xxxxxxxxxxxxxxx, Matthieu Baerts <matthieu.baerts@xxxxxxxxxxxx>, Mat Martineau <martineau@xxxxxxxxxx>, Chuck Lever <chuck.lever@xxxxxxxxxx>, Neil Brown <neilb@xxxxxxx>, linux-nfs@xxxxxxxxxxxxxxx, Mimi Zohar <zohar@xxxxxxxxxxxxx>, linux-integrity@xxxxxxxxxxxxxxx, "Jason A.Donenfeld" <Jason@xxxxxxxxx>, Ayush Sawal <ayush.sawal@xxxxxxxxxxx>
- Subject: Re: [PATCH 6/12] wifi: mac80211: Do not include crypto/algapi.h
- From: Johannes Berg <johannes@xxxxxxxxxxxxxxxx>
- Date: Wed, 23 Aug 2023 12:34:35 +0200
- In-reply-to: <E1qYlA0-006vFr-Ts@formenos.hmeau.com>
- References: <ZOXf3JTIqhRLbn5j@gondor.apana.org.au> <E1qYlA0-006vFr-Ts@formenos.hmeau.com>
- User-agent: Evolution 3.48.4 (3.48.4-1.fc38)
On Wed, 2023-08-23 at 18:32 +0800, Herbert Xu wrote:
> The header file crypto/algapi.h is for internal use only. Use the
> header file crypto/utils.h instead.
>
No objection, of course, but I don't think it's necessarily clear that
it "is for internal use only", it literally says:
* Cryptographic API for algorithms (i.e., low-level API).
which really isn't the same as "don't use this file".
Might want to clarify that, or even move it into crypto/ from
include/crypto/ or something?
johannes
[Index of Archives]
[linux Cryptography]
[Asterisk App Development]
[PJ SIP]
[Gnu Gatekeeper]
[IETF Sipping]
[Info Cyrus]
[ALSA User]
[Fedora Linux Users]
[Linux SCTP]
[DCCP]
[Gimp]
[Yosemite News]
[Deep Creek Hot Springs]
[Yosemite Campsites]
[ISDN Cause Codes]