On Tue, Aug 08, 2023 at 01:08:04PM -0400, Sweet Tea Dorminy wrote: > The function named fscrypt_setup_v2_file_key() has as its main focus the > setting up of the fscrypt_info's ci_enc_key member, the prepared key > with which filenames or file contents are encrypted or decrypted. > However, it currently also sets up the dirhash key, used by some > directories, based on a parameter. There are no dependencies on > setting up the dirhash key beyond having the master key locked, and it's > clearer having fscrypt_setup_file_key() be only about setting up the > prepared key for IO. > > Thus, move dirhash key setup to fscrypt_setup_encryption_info(), which > calls out to each function setting up parts of the fscrypt_info, and > stop passing the need_dirhash_key parameter around. > > Signed-off-by: Sweet Tea Dorminy <sweettea-kernel@xxxxxxxxxx> Reviewed-by: Josef Bacik <josef@xxxxxxxxxxxxxx> Thanks, Josef