On Tue, Feb 7, 2023 at 10:21 PM Eric Biggers <ebiggers@xxxxxxxxxx> wrote:
>
> I was going back and forth between this solution and instead having ext4
> and f2fs call fscrypt_destroy_keyring() on ->fill_super failure. (Or
> using Linus's suggestion of adding the test dummy key as the very last
> step of ->fill_super.) It does seem ideal to add the key at mount time,
> but I ended up going with this solution instead because it reduces the
> number of things the individual filesystems have to handle.
Well, the diffstat certainly looks nice:
> 8 files changed, 34 insertions(+), 51 deletions(-)
with that
> fs/super.c | 1 -
removing the offending line that made Dan's static detection tool so
unhappy, so this all looks lovely to me.
Thanks,
Linus
|