Re: [PATCH v3 1/2] blk-crypto: Add support for SM4-XTS blk crypto mode
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- To: Tianjia Zhang <tianjia.zhang@xxxxxxxxxxxxxxxxx>, Eric Biggers <ebiggers@xxxxxxxxxx>, "Theodore Y. Ts o" <tytso@xxxxxxx>, Jaegeuk Kim <jaegeuk@xxxxxxxxxx>, Jonathan Corbet <corbet@xxxxxxx>, Jens Axboe <axboe@xxxxxxxxx>, Ard Biesheuvel <ardb@xxxxxxxxxx>, linux-fscrypt@xxxxxxxxxxxxxxx, linux-doc@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, linux-block@xxxxxxxxxxxxxxx
- Subject: Re: [PATCH v3 1/2] blk-crypto: Add support for SM4-XTS blk crypto mode
- From: Bagas Sanjaya <bagasdotme@xxxxxxxxx>
- Date: Mon, 28 Nov 2022 20:26:38 +0700
- In-reply-to: <20221125121630.87793-2-tianjia.zhang@linux.alibaba.com>
- References: <20221125121630.87793-1-tianjia.zhang@linux.alibaba.com> <20221125121630.87793-2-tianjia.zhang@linux.alibaba.com>
- User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0
On 11/25/22 19:16, Tianjia Zhang wrote:
> SM4 is a symmetric algorithm widely used in China, and SM4-XTS is also
> used to encrypt length-preserving data, these algoritms are mandatory
> in many scenarios. This patch enables the use of SM4-XTS algorithm in
> block inline encryption, and provides support for fscrypt.
>
Please reformulate the patch description in imperative mood instead.
Also, take care of wording and punctuation - commas should not be
used for continuing distinct sentences/clauses where separating them
by a full stop is more appropriate.
That is, the description should be:
```
SM4 is a symmetric cipher algorithm widely used in China. The SM4-XTS
variant is used to encrypt length-preserving data.
Enable the algorithm in block inline encryption, as well as enable
fscrypt support.
```
Thanks.
--
An old man doll... just what I always wanted! - Clara
[Index of Archives]
[linux Cryptography]
[Asterisk App Development]
[PJ SIP]
[Gnu Gatekeeper]
[IETF Sipping]
[Info Cyrus]
[ALSA User]
[Fedora Linux Users]
[Linux SCTP]
[DCCP]
[Gimp]
[Yosemite News]
[Deep Creek Hot Springs]
[Yosemite Campsites]
[ISDN Cause Codes]