On 9/9/22 9:00 AM, Christoph Hellwig wrote:
On Fri, Sep 09, 2022 at 12:15:21PM +0200, David Sterba wrote:+// SPDX-License-Identifier: GPL-2.0 +/* + * Copyright (C) 2020 Facebook + */Please use only SPDX in new files https://btrfs.wiki.kernel.org/index.php/Developer%27s_FAQ#Copyright_notices_in_files.2C_SPDXThe wiki is incorrect. The SPDX tag deals with the licensing tags only. It is not a replacement for the copyright notice in any way, and having been involved with Copyright enforcement I can tell you that at least in some jurisdictions Copytight notices absolutely do matter.
I agree, SPDX != copyright, and they should probably be in different paragraphs in the wiki because it's misleading as it stands.
Signed-off-by is targeted at declaring that you have permission to put this code into this project, which is somewhat different from copyright.
For Meta code, I'm happy to use the git history method. But, I'm not completely comfortable with enforcing that on other companies or individuals unless it's common practice elsewhere in the kernel.
-chris