Hi Boris,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on kdave/for-next]
[also build test WARNING on next-20220728]
[cannot apply to fscrypt/fsverity linus/master v5.19-rc8]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Boris-Burkov/btrfs-send-add-support-for-fs-verity/20220729-021228
base: https://git.kernel.org/pub/scm/linux/kernel/git/kdave/linux.git for-next
config: i386-randconfig-s002 (https://download.01.org/0day-ci/archive/20220731/202207311836.xrPNTFhA-lkp@xxxxxxxxx/config)
compiler: gcc-11 (Debian 11.3.0-3) 11.3.0
reproduce:
# apt-get install sparse
# sparse version: v0.6.4-39-gce1a6720-dirty
# https://github.com/intel-lab-lkp/linux/commit/cd0224725d17f6e9ebabdddeea5bc5743a9250ae
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Boris-Burkov/btrfs-send-add-support-for-fs-verity/20220729-021228
git checkout cd0224725d17f6e9ebabdddeea5bc5743a9250ae
# save the config file
mkdir build_dir && cp config build_dir/.config
make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=i386 SHELL=/bin/bash fs/btrfs/
If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@xxxxxxxxx>
sparse warnings: (new ones prefixed by >>)
>> fs/btrfs/send.c:4906:9: sparse: sparse: incorrect type in argument 4 (different base types) @@ expected int len @@ got restricted __le32 [usertype] sig_size @@
fs/btrfs/send.c:4906:9: sparse: expected int len
fs/btrfs/send.c:4906:9: sparse: got restricted __le32 [usertype] sig_size
vim +4906 fs/btrfs/send.c
4892
4893 static int send_verity(struct send_ctx *sctx, struct fs_path *path,
4894 struct fsverity_descriptor *desc)
4895 {
4896 int ret;
4897
4898 ret = begin_cmd(sctx, BTRFS_SEND_C_ENABLE_VERITY);
4899 if (ret < 0)
4900 goto out;
4901
4902 TLV_PUT_PATH(sctx, BTRFS_SEND_A_PATH, path);
4903 TLV_PUT_U8(sctx, BTRFS_SEND_A_VERITY_ALGORITHM, desc->hash_algorithm);
4904 TLV_PUT_U32(sctx, BTRFS_SEND_A_VERITY_BLOCK_SIZE, 1U << desc->log_blocksize);
4905 TLV_PUT(sctx, BTRFS_SEND_A_VERITY_SALT_DATA, desc->salt, desc->salt_size);
> 4906 TLV_PUT(sctx, BTRFS_SEND_A_VERITY_SIG_DATA, desc->signature, desc->sig_size);
4907
4908 ret = send_cmd(sctx);
4909
4910 tlv_put_failure:
4911 out:
4912 return ret;
4913 }
4914
--
0-DAY CI Kernel Test Service
https://01.org/lkp
|