On Mon, Jul 18, 2022 at 04:58:30PM -0700, Boris Burkov wrote: > +# btrfs will return IO errors on corrupted data with or without fs-verity. > +# to really test fs-verity, use nodatasum. > +if [ "$FSTYP" == "btrfs" ]; then > + if [ -z $MOUNT_OPTIONS ]; then > + export MOUNT_OPTIONS="-o nodatasum" > + else > + export MOUNT_OPTIONS+=" -o nodatasum" > + fi > +fi $MOUNT_OPTIONS needs to be quoted in the if expression. Otherwise -o is treated as the OR operator. Fun fact, [ -z -o foo ] evaluates to true... > + echo "Checking for SIGBUS or zeros..." > + <$tmp.eof_block_read grep -q -e '^Bus error$' \ This line is odd. It would be easier to read as: grep -q -e '^Bus error$' $tmp.eof_block_read Other than that, this patch looks fine. Thanks! - Eric
|