On Thu, Apr 28, 2022 at 03:19:19PM -0700, Boris Burkov wrote: > diff --git a/fs/verity/signature.c b/fs/verity/signature.c > index 143a530a8008..67a471e4b570 100644 > --- a/fs/verity/signature.c > +++ b/fs/verity/signature.c > @@ -12,11 +12,7 @@ > #include <linux/slab.h> > #include <linux/verification.h> > > -/* > - * /proc/sys/fs/verity/require_signatures > - * If 1, all verity files must have a valid builtin signature. > - */ > -static int fsverity_require_signatures; > +extern int fsverity_require_signatures; This forward declaration should go in fsverity_private.h so that it is also visible at the definition site. Otherwise it causes a compiler warning: fs/verity/sysctl.c:11:5: warning: symbol 'fsverity_require_signatures' was not declared. Should it be static? > diff --git a/fs/verity/sysctl.c b/fs/verity/sysctl.c > new file mode 100644 > index 000000000000..3ba7b02282db > --- /dev/null > +++ b/fs/verity/sysctl.c > @@ -0,0 +1,51 @@ > +// SPDX-License-Identifier: GPL-2.0 > + Please keep the existing copyright statements when moving code. - Eric
|