On Fri, May 13, 2022 at 04:37:41PM +0530, Ritesh Harjani wrote: > > @@ -2623,10 +2609,11 @@ static int parse_apply_sb_mount_options(struct super_block *sb, > > if (s_ctx->spec & EXT4_SPEC_JOURNAL_IOPRIO) > > m_ctx->journal_ioprio = s_ctx->journal_ioprio; > > > > - ret = ext4_apply_options(fc, sb); > > + ext4_apply_options(fc, sb); > > + ret = 0; > > > > out_free: > > - kfree(s_ctx); > > + __ext4_fc_free(s_ctx); > > I think we can still call ext4_fc_free(fc) and we don't need __ext4_fc_free(). > Right? > Yes, you're right. I might have missed that fc->fs_private was being set above. I was also a little lazy here; the part below 'out_free:' should be a separate patch since it also fixes a memory leak of s_qf_names. I'll fix that up. - Eric
|