On Fri, 2021-07-23 at 01:16 -0700, Eric Biggers wrote: > On Sat, Jul 17, 2021 at 07:01:25PM -0500, Eric Biggers wrote: > > > > There have been two attempts to copy the fscrypt Base64 code into lib/ > > (https://lkml.kernel.org/r/20200821182813.52570-6-jlayton@xxxxxxxxxx and > > https://lkml.kernel.org/r/20210716110428.9727-5-hare@xxxxxxx), and both > > have been caught up by the fscrypt Base64 variant being nonstandard and > > not properly documented. Also, the planned use of the fscrypt Base64 > > code in the CephFS storage back-end will prevent it from being changed > > later (whereas currently it can still be changed), so we need to choose > > an encoding that we're happy with before it's too late. > > Jeff, any thoughts on whether this is the variant of Base64 you want to use in > the CephFS fscrypt support? > I can't do a deep review today, but this looks fine at first glance. We're not too particular about what sort of encoding we use for ceph. We just need something that is consistent and results in valid POSIX filenames. Changing it to better adhere to the standard sounds like a good thing to do. Thanks, -- Jeff Layton <jlayton@xxxxxxxxxx>
|