On Wed, May 05, 2021 at 02:04:45PM -0700, Boris Burkov wrote:
> The behavior of orphans is most interesting across mounts, interrupted
> at arbitrary points during fsverity enable. To cover as many such cases
> as possible, use dmlogwrites and dmsnapshot as in
> log-writes/replay-individual.sh. At each log entry, we want to assert a
> somewhat complicated invariant:
>
> If verity has not yet started: an orphan indicates that verity has
> started.
> If verity has started: mount should handle the orphan and blow away
> verity data: expect 0 merkle items after mounting the snapshot dev. If
> we can measure the file, verity has finished.
> If verity has finished: the orphan should be gone, so mount should not
> blow away merkle items. Expect the same number of merkle items before
> and after mounting the snapshot dev.
>
> Note that this relies on grepping btrfs inspect-internal dump-tree.
> Until btrfs-progs has the ability to print the new Merkle items, they
> will show up as UNKNOWN.36/37.
>
> Signed-off-by: Boris Burkov <boris@xxxxxx>
> ---
> tests/btrfs/291 | 157 ++++++++++++++++++++++++++++++++++++++++++++
> tests/btrfs/291.out | 2 +
> tests/btrfs/group | 1 +
> 3 files changed, 160 insertions(+)
> create mode 100755 tests/btrfs/291
> create mode 100644 tests/btrfs/291.out
>
> diff --git a/tests/btrfs/291 b/tests/btrfs/291
> new file mode 100755
> index 00000000..eab3a495
> --- /dev/null
> +++ b/tests/btrfs/291
> @@ -0,0 +1,157 @@
> +#! /bin/bash
> +# SPDX-License-Identifier: GPL-2.0
> +# Copyright (C) 2021 Facebook, Inc. All Rights Reserved.
> +#
> +# FS QA Test 291
> +#
> +# Test btrfs consistency after each FUA while enabling verity on a file
> +# This test works by following the pattern in log-writes/replay-individual.sh:
> +# 1. run a workload (verity + sync) while logging to the log device
> +# 2. replay an entry to the replay device
> +# 3. snapshot the replay device to the snapshot device
> +# 4. run destructive tests on the snapshot device (e.g. mount with orphans)
> +# 5. goto 2
> +#
> +seq=`basename $0`
> +seqres=$RESULT_DIR/$seq
> +echo "QA output created by $seq"
> +
> +here=`pwd`
> +tmp=/tmp/$$
> +status=1 # failure is the default!
> +trap "_cleanup; exit \$status" 0 1 2 3 15
> +
> +_cleanup()
> +{
> + cd /
> + _log_writes_cleanup &> /dev/null
> + rm -f $tmp.*
> + $LVM_PROG vgremove -f -y $vgname >>$seqres.full 2>&1
> + losetup -d $loop_dev >>$seqres.full 2>&1
> +}
> +
> +# get standard environment, filters and checks
> +. ./common/rc
> +. ./common/filter
> +. ./common/attr
> +. ./common/dmlogwrites
> +. ./common/verity
> +
> +# remove previous $seqres.full before test
> +rm -f $seqres.full
> +
> +# real QA test starts here
> +
> +_supported_fs btrfs
> +
> +_require_scratch
> +_require_log_writes
> +_require_dm_target snapshot
> +_require_command $LVM_PROG lvm
> +_require_scratch_verity
Also need
_require_btrfs_command inspect-internal dump-tree
_require_test_program "log-writes/replay-log"
> +
> +sync_loop() {
> + i=$1
> + [ -z "$i" ] && _fail "sync loop needs a number of iterations"
> + while [ $i -gt 0 ]
> + do
> + $XFS_IO_PROG -c sync $SCRATCH_MNT
> + let i-=1
> + done
> +}
> +
> +dump_tree() {
> + local dev=$1
> + $BTRFS_UTIL_PROG inspect-internal dump-tree $dev
> +}
> +
> +count_item() {
> + local dev=$1
> + local item=$2
> + dump_tree $dev | grep -c $item
> +}
> +
> +_log_writes_init $SCRATCH_DEV
> +_log_writes_mkfs
> +_log_writes_mount
> +
> +f=$SCRATCH_MNT/fsv
> +MB=$((1024 * 1024))
> +$XFS_IO_PROG -fc "pwrite -q 0 $((10 * $MB))" $f
> +$XFS_IO_PROG -c sync $SCRATCH_MNT
> +sync_loop 10 &
> +_fsv_enable $f
> +$XFS_IO_PROG -c sync $SCRATCH_MNT
> +
> +_log_writes_unmount
> +_log_writes_remove
> +
> +$XFS_IO_PROG -fc "pwrite -q -S 0 $((8192 * $MB)) $MB" $tmp.loop-file
Better to create fs image file for loop dev under $TEST_DIR. Then we
need _require_test as well.
Thanks,
Eryu
> +loop_dev=$(losetup -f --show $tmp.loop-file)
> +vgname=vg_replay
> +lvname=lv_replay
> +replay_dev=/dev/mapper/vg_replay-lv_replay
> +snapname=lv_snap
> +snap_dev=/dev/mapper/vg_replay-$snapname
> +
> +$LVM_PROG vgcreate -f $vgname $loop_dev >>$seqres.full 2>&1 || _fail "failed to vgcreate $vgname"
> +$LVM_PROG lvcreate -L 4G -n $lvname $vgname -y >>$seqres.full 2>&1 || \
> + _fail "failed to lvcreate $lvname"
> +$UDEV_SETTLE_PROG >>$seqres.full 2>&1
> +
> +replay_log_prog=$here/src/log-writes/replay-log
> +num_entries=$($replay_log_prog --log $LOGWRITES_DEV --num-entries)
> +entry=$($replay_log_prog --log $LOGWRITES_DEV --replay $replay_dev --find --end-mark mkfs | cut -d@ -f1)
> +$replay_log_prog --log $LOGWRITES_DEV --replay $replay_dev --limit $entry || \
> + _fail "failed to replay to start entry $entry"
> +let entry+=1
> +
> +# state = 0: verity hasn't started
> +# state = 1: verity underway
> +# state = 2: verity done
> +state=0
> +while [ $entry -lt $num_entries ];
> +do
> + $replay_log_prog --limit 1 --log $LOGWRITES_DEV --replay $replay_dev --start $entry || \
> + _fail "failed to take replay step at entry: $entry"
> +
> + $LVM_PROG lvcreate -s -L 4M -n $snapname $vgname/$lvname >>$seqres.full 2>&1 || \
> + _fail "Failed to create snapshot"
> + $UDEV_SETTLE_PROG >>$seqres.full 2>&1
> +
> + orphan=$(count_item $snap_dev ORPHAN)
> + if [ $state -eq 0 ]; then
> + [ $orphan -gt 0 ] && state=1
> + fi
> +
> + pre_mount=$(count_item $snap_dev UNKNOWN.3[67])
> + _mount $snap_dev $SCRATCH_MNT || _fail "mount failed at entry $entry"
> + fsverity measure $SCRATCH_MNT/fsv >>$seqres.full 2>&1
> + measured=$?
> + umount $SCRATCH_MNT
> + [ $state -eq 1 ] && [ $measured -eq 0 ] && state=2
> + [ $state -eq 2 ] && ([ $measured -eq 0 ] || _fail "verity done, but measurement failed at entry $entry")
> + post_mount=$(count_item $snap_dev UNKNOWN.3[67])
> +
> + echo "entry: $entry, state: $state, orphan: $orphan, pre_mount: $pre_mount, post_mount: $post_mount" >> $seqres.full
> +
> + if [ $state -eq 1 ]; then
> + [ $post_mount -eq 0 ] || \
> + _fail "mount failed to clear under-construction merkle items pre: $pre_mount, post: $post_mount at entry $entry";
> + fi
> + if [ $state -eq 2 ]; then
> + [ $pre_mount -gt 0 ] || \
> + _fail "expected to have verity items before mount at entry $entry"
> + [ $pre_mount -eq $post_mount ] || \
> + _fail "mount cleared merkle items after verity was enabled $pre_mount vs $post_mount at entry $entry";
> + fi
> +
> + let entry+=1
> + $LVM_PROG lvremove $vgname/$snapname -y >>$seqres.full
> +done
> +
> +echo "Silence is golden"
> +
> +# success, all done
> +status=0
> +exit
> diff --git a/tests/btrfs/291.out b/tests/btrfs/291.out
> new file mode 100644
> index 00000000..04605c70
> --- /dev/null
> +++ b/tests/btrfs/291.out
> @@ -0,0 +1,2 @@
> +QA output created by 291
> +Silence is golden
> diff --git a/tests/btrfs/group b/tests/btrfs/group
> index 13051562..cc5a811e 100644
> --- a/tests/btrfs/group
> +++ b/tests/btrfs/group
> @@ -239,3 +239,4 @@
> 234 auto quick compress rw
> 235 auto quick send
> 290 auto quick verity
> +291 auto verity
> --
> 2.30.2
|