Hi Boris,
I love your patch! Yet something to improve:
[auto build test ERROR on v5.12-rc2]
[also build test ERROR on next-20210305]
[cannot apply to kdave/for-next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Boris-Burkov/btrfs-support-fsverity/20210307-105111
base: a38fd8748464831584a19438cbb3082b5a2dab15
config: i386-randconfig-m021-20210307 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build):
# https://github.com/0day-ci/linux/commit/230ae9030c4636229de25a9013d979fc8e04f459
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Boris-Burkov/btrfs-support-fsverity/20210307-105111
git checkout 230ae9030c4636229de25a9013d979fc8e04f459
# save the attached .config to linux build tree
make W=1 ARCH=i386
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@xxxxxxxxx>
All errors (new ones prefixed by >>):
fs/btrfs/super.c: In function 'btrfs_fill_super':
>> fs/btrfs/super.c:1342:6: error: 'struct super_block' has no member named 's_vop'; did you mean 's_op'?
1342 | sb->s_vop = &btrfs_verityops;
| ^~~~~
| s_op
vim +1342 fs/btrfs/super.c
1328
1329 static int btrfs_fill_super(struct super_block *sb,
1330 struct btrfs_fs_devices *fs_devices,
1331 void *data)
1332 {
1333 struct inode *inode;
1334 struct btrfs_fs_info *fs_info = btrfs_sb(sb);
1335 int err;
1336
1337 sb->s_maxbytes = MAX_LFS_FILESIZE;
1338 sb->s_magic = BTRFS_SUPER_MAGIC;
1339 sb->s_op = &btrfs_super_ops;
1340 sb->s_d_op = &btrfs_dentry_operations;
1341 sb->s_export_op = &btrfs_export_ops;
> 1342 sb->s_vop = &btrfs_verityops;
1343 sb->s_xattr = btrfs_xattr_handlers;
1344 sb->s_time_gran = 1;
1345 #ifdef CONFIG_BTRFS_FS_POSIX_ACL
1346 sb->s_flags |= SB_POSIXACL;
1347 #endif
1348 sb->s_flags |= SB_I_VERSION;
1349 sb->s_iflags |= SB_I_CGROUPWB;
1350
1351 err = super_setup_bdi(sb);
1352 if (err) {
1353 btrfs_err(fs_info, "super_setup_bdi failed");
1354 return err;
1355 }
1356
1357 err = open_ctree(sb, fs_devices, (char *)data);
1358 if (err) {
1359 btrfs_err(fs_info, "open_ctree failed");
1360 return err;
1361 }
1362
1363 inode = btrfs_iget(sb, BTRFS_FIRST_FREE_OBJECTID, fs_info->fs_root);
1364 if (IS_ERR(inode)) {
1365 err = PTR_ERR(inode);
1366 goto fail_close;
1367 }
1368
1369 sb->s_root = d_make_root(inode);
1370 if (!sb->s_root) {
1371 err = -ENOMEM;
1372 goto fail_close;
1373 }
1374
1375 cleancache_init_fs(sb);
1376 sb->s_flags |= SB_ACTIVE;
1377 return 0;
1378
1379 fail_close:
1380 close_ctree(fs_info);
1381 return err;
1382 }
1383
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx
Attachment:
.config.gz
Description: application/gzip
|