Re: [PATCH] block/keyslot-manager: prevent crash when num_slots=1

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Eric Biggers <ebiggers@xxxxxxxxxx>
Subject: Re: [PATCH] block/keyslot-manager: prevent crash when num_slots=1
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Wed, 11 Nov 2020 09:23:05 +0000
In-reply-to: <20201111021427.466349-1-ebiggers@kernel.org>
References: <20201111021427.466349-1-ebiggers@kernel.org>

On Tue, Nov 10, 2020 at 06:14:27PM -0800, Eric Biggers wrote:
> +	 * hash_ptr() assumes bits != 0, so ensure the hash table has at least 2
> +	 * buckets.  This only makes a difference when there is only 1 keyslot.
> +	 */
> +	slot_hashtable_size = max(slot_hashtable_size, 2U);

shouldn't this be a min()?

Follow-Ups:
- Re: [PATCH] block/keyslot-manager: prevent crash when num_slots=1
  - From: Satya Tangirala

References:
- [PATCH] block/keyslot-manager: prevent crash when num_slots=1
  - From: Eric Biggers

Prev by Date: [PATCH] block/keyslot-manager: prevent crash when num_slots=1
Next by Date: Re: [PATCH] block/keyslot-manager: prevent crash when num_slots=1
Previous by thread: [PATCH] block/keyslot-manager: prevent crash when num_slots=1
Next by thread: Re: [PATCH] block/keyslot-manager: prevent crash when num_slots=1
Index(es):
- Date
- Thread

[Index of Archives] [linux Cryptography] [Asterisk App Development] [PJ SIP] [Gnu Gatekeeper] [IETF Sipping] [Info Cyrus] [ALSA User] [Fedora Linux Users] [Linux SCTP] [DCCP] [Gimp] [Yosemite News] [Deep Creek Hot Springs] [Yosemite Campsites] [ISDN Cause Codes]

Powered by Linux