On 5/15/20 12:10 AM, Eric Biggers wrote: > From: Eric Biggers <ebiggers@xxxxxxxxxx> > > In preparation for moving most of the functionality of 'fsverity sign' > into a shared library, split up cmd_sign.c into three files: > > - cmd_sign.c: the actual command > - compute_digest.c: computing the file measurement > - sign_digest.c: sign the file measurement > > No "real" changes; this is just moving code around. > > Signed-off-by: Eric Biggers <ebiggers@xxxxxxxxxx> > --- > Makefile | 4 +- > cmd_sign.c | 481 +------------------------------------------ > lib/compute_digest.c | 184 +++++++++++++++++ > lib/sign_digest.c | 304 +++++++++++++++++++++++++++ > sign.h | 32 +++ > 5 files changed, 523 insertions(+), 482 deletions(-) > create mode 100644 lib/compute_digest.c > create mode 100644 lib/sign_digest.c > create mode 100644 sign.h I don't really have specific comments to this one, except for the u8/u16/u32 datatype issue I mentioned in the the 2/3 patch. Reviewed-by: Jes Sorensen <jsorensen@xxxxxx> Thanks, Jes