On 2020/5/7 15:59, Eric Biggers wrote: > From: Eric Biggers <ebiggers@xxxxxxxxxx> > > Sharing f2fs_ci_compare() between comparing cached dentries > (f2fs_d_compare()) and comparing on-disk dentries (f2fs_match_name()) > doesn't work as well as intended, as these actions fundamentally differ > in several ways (e.g. whether the task may sleep, whether the directory > is stable, whether the casefolded name was precomputed, whether the > dentry will need to be decrypted once we allow casefold+encrypt, etc.) > > Just make f2fs_d_compare() implement what it needs directly, and rework > f2fs_ci_compare() to be specialized for f2fs_match_name(). > > Signed-off-by: Eric Biggers <ebiggers@xxxxxxxxxx> Reviewed-by: Chao Yu <yuchao0@xxxxxxxxxx> Thanks,