On 3/22/20 1:33 AM, Eric Biggers wrote: > On Thu, Mar 12, 2020 at 05:47:50PM -0400, Jes Sorensen wrote: >> From: Jes Sorensen <jsorensen@xxxxxx> >> >> This introduces a dummy shared library to start moving things into. >> >> Signed-off-by: Jes Sorensen <jsorensen@xxxxxx> >> --- >> Makefile | 18 +++++++++++++++--- >> libverity.c | 10 ++++++++++ >> 2 files changed, 25 insertions(+), 3 deletions(-) >> create mode 100644 libverity.c >> >> diff --git a/Makefile b/Makefile >> index b9c09b9..bb85896 100644 >> --- a/Makefile >> +++ b/Makefile >> @@ -1,20 +1,32 @@ >> EXE := fsverity >> +LIB := libfsverity.so >> CFLAGS := -O2 -Wall >> CPPFLAGS := -D_FILE_OFFSET_BITS=64 >> LDLIBS := -lcrypto >> DESTDIR := /usr/local >> +LIBDIR := /usr/lib64 > > LIBDIR isn't used at all. I assume you meant for it to be location where the > library gets installed? The proper way to handle installation locations > (assuming we stay with a plain Makefile and not move to another build system) > would be: > > PREFIX ?= /usr/local > BINDIR ?= $(PREFIX)/bin > INCDIR ?= $(PREFIX)/include > LIBDIR ?= $(PREFIX)/lib > > then install binaries into $(DESTDIR)$(BINDIR), headers into > $(DESTDIR)$(INCDIR), and libraries into $(DESTDIR)$(LIBDIR). > This matches the conventions for autoconf. I pushed a change to git which addresses this, I still need to address the soname though. Long term it might be nice to switch to autoconf/automake, at the same time I love dealing with it about as much as going to the dentist for a root canal. Cheers, Jes
|