Re: [PATCH 1/2] mm, treewide: Rename kzfree() to kfree_sensitive()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Waiman Long <longman@xxxxxxxxxx>
Subject: Re: [PATCH 1/2] mm, treewide: Rename kzfree() to kfree_sensitive()
From: David Sterba <dsterba@xxxxxxx>
Date: Tue, 14 Apr 2020 14:48:54 +0200
In-reply-to: <20200413211550.8307-2-longman@redhat.com>
Mail-followup-to: dsterba@xxxxxxx, Waiman Long <longman@xxxxxxxxxx>, Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>, David Howells <dhowells@xxxxxxxxxx>, Jarkko Sakkinen <jarkko.sakkinen@xxxxxxxxxxxxxxx>, James Morris <jmorris@xxxxxxxxx>, "Serge E. Hallyn" <serge@xxxxxxxxxx>, Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>, Joe Perches <joe@xxxxxxxxxxx>, Matthew Wilcox <willy@xxxxxxxxxxxxx>, David Rientjes <rientjes@xxxxxxxxxx>, linux-mm@xxxxxxxxx, keyrings@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, x86@xxxxxxxxxx, linux-crypto@xxxxxxxxxxxxxxx, linux-s390@xxxxxxxxxxxxxxx, linux-pm@xxxxxxxxxxxxxxx, linux-stm32@xxxxxxxxxxxxxxxxxxxxxxxxxxxx, linux-arm-kernel@xxxxxxxxxxxxxxxxxxx, linux-amlogic@xxxxxxxxxxxxxxxxxxx, linux-mediatek@xxxxxxxxxxxxxxxxxxx, linuxppc-dev@xxxxxxxxxxxxxxxx, virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx, netdev@xxxxxxxxxxxxxxx, intel-wired-lan@xxxxxxxxxxxxxxxx, linux-ppp@xxxxxxxxxxxxxxx, wireguard@xxxxxxxxxxxxxxx, linux-wireless@xxxxxxxxxxxxxxx, devel@xxxxxxxxxxxxxxxxxxxx, linux-scsi@xxxxxxxxxxxxxxx, target-devel@xxxxxxxxxxxxxxx, linux-btrfs@xxxxxxxxxxxxxxx, linux-cifs@xxxxxxxxxxxxxxx, samba-technical@xxxxxxxxxxxxxxx, linux-fscrypt@xxxxxxxxxxxxxxx, ecryptfs@xxxxxxxxxxxxxxx, kasan-dev@xxxxxxxxxxxxxxxx, linux-bluetooth@xxxxxxxxxxxxxxx, linux-wpan@xxxxxxxxxxxxxxx, linux-sctp@xxxxxxxxxxxxxxx, linux-nfs@xxxxxxxxxxxxxxx, tipc-discussion@xxxxxxxxxxxxxxxxxxxxx, cocci@xxxxxxxxxxxxxxx, linux-security-module@xxxxxxxxxxxxxxx, linux-integrity@xxxxxxxxxxxxxxx
References: <20200413211550.8307-1-longman@redhat.com> <20200413211550.8307-2-longman@redhat.com>
User-agent: Mutt/1.5.23.1-rc1 (2014-03-12)

On Mon, Apr 13, 2020 at 05:15:49PM -0400, Waiman Long wrote:
>  fs/btrfs/ioctl.c                              |  2 +-


> diff --git a/fs/btrfs/ioctl.c b/fs/btrfs/ioctl.c
> index 40b729dce91c..eab3f8510426 100644
> --- a/fs/btrfs/ioctl.c
> +++ b/fs/btrfs/ioctl.c
> @@ -2691,7 +2691,7 @@ static int btrfs_ioctl_get_subvol_info(struct file *file, void __user *argp)
>  	btrfs_put_root(root);
>  out_free:
>  	btrfs_free_path(path);
> -	kzfree(subvol_info);
> +	kfree_sensitive(subvol_info);

This is not in a sensitive context so please switch it to plain kfree.
With that you have my acked-by. Thanks.

Follow-Ups:
- Re: [PATCH 1/2] mm, treewide: Rename kzfree() to kfree_sensitive()
  - From: Waiman Long

References:
- [PATCH 0/2] mm, treewide: Rename kzfree() to kfree_sensitive()
  - From: Waiman Long
- [PATCH 1/2] mm, treewide: Rename kzfree() to kfree_sensitive()
  - From: Waiman Long

Prev by Date: Re: [PATCH 1/2] mm, treewide: Rename kzfree() to kfree_sensitive()
Next by Date: Re: [PATCH 1/2] mm, treewide: Rename kzfree() to kfree_sensitive()
Previous by thread: Re: [PATCH 1/2] mm, treewide: Rename kzfree() to kfree_sensitive()
Next by thread: Re: [PATCH 1/2] mm, treewide: Rename kzfree() to kfree_sensitive()
Index(es):
- Date
- Thread

[Index of Archives] [linux Cryptography] [Asterisk App Development] [PJ SIP] [Gnu Gatekeeper] [IETF Sipping] [Info Cyrus] [ALSA User] [Fedora Linux Users] [Linux SCTP] [DCCP] [Gimp] [Yosemite News] [Deep Creek Hot Springs] [Yosemite Campsites] [ISDN Cause Codes]