On Sun, Feb 2, 2020 at 5:46 PM Gabriel Krisman Bertazi <krisman@xxxxxxxxxxxxx> wrote: > > > I don't think fs/unicode is the right place for these very specific > filesystem functions, just because they happen to use unicode. It is an > encoding library, it doesn't care about dentries, nor should know how to > handle them. It exposes a simple api to manipulate and convert utf8 strings. > > I saw change was after the desire to not have these functions polluting > the VFS hot path, but that has nothing to do with placing them here. > > Would libfs be better? or a casefolding library in fs/casefold.c? > > > -- > Gabriel Krisman Bertazi The hash function needs access to utf8ncursor, but apart from that, libfs would make sense. utf8ncursor is the only reason I have them here. How do you feel about exposing utf8cursor or something similar?
|