Re: [PATCH] ext4: handle decryption error in __ext4_block_zero_page_range()

["Theodore Y. Ts'o" <tytso@xxxxxxx>]

On Thu, Dec 26, 2019 at 09:41:05AM -0600, Eric Biggers wrote:
> From: Eric Biggers <ebiggers@xxxxxxxxxx>
> 
> fscrypt_decrypt_pagecache_blocks() can fail, because it uses
> skcipher_request_alloc(), which uses kmalloc(), which can fail; and also
> because it calls crypto_skcipher_decrypt(), which can fail depending on
> the driver that actually implements the crypto.
> 
> Therefore it's not appropriate to WARN on decryption error in
> __ext4_block_zero_page_range().
> 
> Remove the WARN and just handle the error instead.
> 
> Signed-off-by: Eric Biggers <ebiggers@xxxxxxxxxx>

Thanks, applied.

					- Ted