Re: [PATCH v6 2/9] block: Add encryption context to struct bio
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- To: "Darrick J. Wong" <darrick.wong@xxxxxxxxxx>
- Subject: Re: [PATCH v6 2/9] block: Add encryption context to struct bio
- From: "Martin K. Petersen" <martin.petersen@xxxxxxxxxx>
- Date: Wed, 18 Dec 2019 16:25:28 -0500
- In-reply-to: <20191218212116.GA7476@magnolia> (Darrick J. Wong's message of "Wed, 18 Dec 2019 13:21:16 -0800")
- Organization: Oracle Corporation
- References: <20191218145136.172774-1-satyat@google.com> <20191218145136.172774-3-satyat@google.com> <20191218212116.GA7476@magnolia>
- User-agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.92 (gnu/linux)
Darrick,
>> +#ifdef CONFIG_BLK_INLINE_ENCRYPTION
>> + struct bio_crypt_ctx *bi_crypt_context;
>> +#endif
>
> This grows struct bio even if we aren't actively using bi_crypt_context,
> and I thought Jens told us to stop making it bigger. :)
Yeah. Why not use the bio integrity plumbing? It was explicitly designed
to attach things to a bio and have them consumed by the device driver.
--
Martin K. Petersen Oracle Linux Engineering
[Index of Archives]
[linux Cryptography]
[Asterisk App Development]
[PJ SIP]
[Gnu Gatekeeper]
[IETF Sipping]
[Info Cyrus]
[ALSA User]
[Fedora Linux Users]
[Linux SCTP]
[DCCP]
[Gimp]
[Yosemite News]
[Deep Creek Hot Springs]
[Yosemite Campsites]
[ISDN Cause Codes]