On Wed, Nov 27, 2019 at 10:45:36PM +0200, Jarkko Sakkinen wrote: > On Tue, Nov 19, 2019 at 02:31:27PM -0800, Eric Biggers wrote: > > This series adds a test which tests adding a key to a filesystem's > > fscrypt keyring via an "fscrypt-provisioning" keyring key. This is an > > alternative to the normal method where the raw key is given directly. > > > > I'm sending this out for comment, but it shouldn't be merged until the > > corresponding kernel patch has reached mainline. For more details, see > > the kernel patch: > > https://lkml.kernel.org/linux-fscrypt/20191119222447.226853-1-ebiggers@xxxxxxxxxx/T/#u > > > > This test depends on an xfs_io patch which adds the '-k' option to the > > 'add_enckey' command, e.g.: > > > > xfs_io -c "add_enckey -k KEY_ID" MOUNTPOINT > > > > This test is skipped if the needed kernel or xfs_io support is absent. > > > > This has been tested on ext4, f2fs, and ubifs. > > > > To apply cleanly, my other xfstests patch series > > "[RFC PATCH 0/5] xfstests: verify ciphertext of IV_INO_LBLK_64 encryption policies" > > must be applied first. > > > > This series can also be retrieved from > > https://git.kernel.org/pub/scm/linux/kernel/git/ebiggers/xfstests-dev.git > > tag "fscrypt-provisioning_2019-11-19". > > > > Eric Biggers (3): > > common/rc: handle option with argument in _require_xfs_io_command() > > common/encrypt: move constant test key to common code > > generic: test adding filesystem-level fscrypt key via key_id > > > > common/encrypt | 95 +++++++++++++++++++++---- > > common/rc | 2 +- > > tests/generic/580 | 17 ++--- > > tests/generic/806 | 156 ++++++++++++++++++++++++++++++++++++++++++ > > tests/generic/806.out | 73 ++++++++++++++++++++ > > tests/generic/group | 1 + > > 6 files changed, 316 insertions(+), 28 deletions(-) > > create mode 100644 tests/generic/806 > > create mode 100644 tests/generic/806.out > > > > -- > > 2.24.0.432.g9d3f5f5b63-goog > > > > I'm newbie with fscrypt so I started by encrypting a directory without > the new feature > > sudo tune2fs -O encrypt /dev/sda2 > sudo fscrypt setup / > fscrypt encrypt foo > > Worked. > > Generally speaking I'd appreciate a usage example like here to the > commit message: > > https://lwn.net/Articles/692514/ > > Is this doable? > > I might consider trying out the XFS test suite some day but right now it > would be first nice to smoke test the feature quickly. > > I think for this patch that would actually be mostly sufficient testing. Sorry, this was meant for the kernel patch :-/ /Jarkko
|